Add LANG env variable support on macOS#5
Closed
eduardomozart wants to merge 0 commit intoKangLin:masterfrom
Closed
Add LANG env variable support on macOS#5eduardomozart wants to merge 0 commit intoKangLin:masterfrom
eduardomozart wants to merge 0 commit intoKangLin:masterfrom
Conversation
eduardomozart
changed the title
KangLin
force-pushed
the
LANG-macOS
branch
3 times, most recently
from
f12d2fe to
e830236
Compare
Owner
|
Thanks! Merge to master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On macOS, Qt ignores
LANGenvironment variable and uses only system settings to determine the current UI language. On other systems, we can override Qt Language usingLANGenvironment variable.With this PR, if
LANGenvironment variable is available, it overrides the Qt Language detection logic, e.g.:Opens the Rabbit Remote Control on Portuguese (Brazil) even on systems with other locales.
I changed my macOS language to EN-US so you can use it without hassle during remote connections, but I was unable to test the translation of Rabbit Remote Control on macOS for my main language, so this PR allows me to do that.