Add forms #7
Add forms #7
Conversation
There was a problem hiding this comment.
STATUS: CHANGES REQUIRED 🟡
Hi @KanoCode ,
👍 This is good to make it this far, your project is really nice, congratulations on the good work you have done so far.
Good Points 👍
- Using nested routes ✔️
- Descriptive Pull Request ✔️
- No linter errors ✔️
- Professional documentation ✔️
There are some issues that you still need to work on to go to the next project but you are almost there!
Required Changes ♻️
Check the comments under the review.
Optional suggestions
_Every comment with the [OPTIONAL] prefix won't stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better. Some of them were simply missed by the previous reviewer and addressing them will really improve your application.
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.
Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.
As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.
app/controllers/posts_controller.rb
Outdated
| end | ||
|
|
||
| def create | ||
| @user = User.find(params[:user_id]) |
There was a problem hiding this comment.
- OPTIONAL: You can just user
current_userwithout targeting params:
def create
@post = @current_user.posts.new(post_params)
@post.likes_counter = 0
@post.comments_counter = 0
...| def post_params | ||
| params.require(:post).permit(:title, :text, :user_id) | ||
| end |
There was a problem hiding this comment.
- You should be permitting only
titleandtext, no need to explicitly permit :user_id it can be assigned without permission since it is reference
def post_params
params.require(:post).permit(:title, :text)
end| def create | ||
| @post = Post.find(params[:post_id]) | ||
|
|
||
| @comment = @post.comments.new(text: comment_params[:text], user_id: current_user.id, post_id: @post.id) |
There was a problem hiding this comment.
- You should be using
comment_paramsto make sure that only allowed params are assigned.
def create
@comment = @current_user.comments.new(comment_params)
@comment.post_id = params[:post_id]
...| @post = Post.find(params[:post_id]) | ||
| @like = current_user.likes.new(like_params) | ||
| redirect_to user_post_path(user_id: current_user.id, id: @post.id) if @like.save |
There was a problem hiding this comment.
Thank you @ShoiraTa
I will refactor my code
There was a problem hiding this comment.
**STATUS: APPROVED 🟢 **
Hi @KanoCode ,
Great work on making the changes 👏🏻
Your project is complete! . There is nothing else to say other than... it's time to merge it 🍾🚢 
. Congratulations! 🎉💯🌟
Cheers and Happy coding! 👏 👏 👏
Feel free to leave any questions or comments in the PR thread by mentioning my Github username if something is not 100% clear.
As described in the Code reviews limits policy you have limited number of reviews per this project. If you think that the code review was not fair, you can request a second opinion using this form.
In this pull request the following was done:
Created a method called current_user inside ApplicationController.
Created forms to perform the following functions:
Creates a Post on behalf of the current_user (use the method that you created in your ApplicationController).
Create a comment on behalf of the current_user (use the method that you created in your ApplicationController).
Allow Users to add likes to Posts.