Conversation
miral-zymr
requested changes
Mar 25, 2022
miral-zymr
requested changes
Apr 1, 2022
| <div class="container" id="content"> | ||
|
|
||
| <!--Intro div--> | ||
| <div id="intro" style="display: block;"> |
Collaborator
There was a problem hiding this comment.
Please keep the style in the .css file.
| </div> | ||
|
|
||
| <!--String to array div--> | ||
| <div id="string" class="main-content" style="display: none;"> |
Collaborator
There was a problem hiding this comment.
Please keep the style in the .css file.
| <div class="input-output my-3"> | ||
| <div class="input-box my-3"> | ||
| Enter your array here...<br> | ||
| <input type="text" class="arrayValue" id="arrayValue1" name="arrayValue"> |
Collaborator
There was a problem hiding this comment.
Please keep the standard practice of naming classes as per: https://css-tricks.com/bem-101/
The class name here should be: array-value or more generic name.
| </div> | ||
|
|
||
| <!--Last Element div--> | ||
| <div id="lastElement" class="main-content" style="display: none;"> |
Collaborator
There was a problem hiding this comment.
Please keep the style in the .css file.
| </div> | ||
|
|
||
| <!--Pop div--> | ||
| <div id="pop" class="main-content" style="display: none;"> |
Collaborator
There was a problem hiding this comment.
Please keep the style in the .css file.
| ]</span> | ||
| </code> | ||
| </div> | ||
| <div class="input-output my-3"> |
Collaborator
There was a problem hiding this comment.
Class names should be self-explanatory.
| @@ -0,0 +1,173 @@ | |||
| * { | |||
Collaborator
There was a problem hiding this comment.
Try using variables: https://developer.mozilla.org/en-US/docs/Web/CSS/Using_CSS_custom_properties
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is array introduction single page site.
Created with HTML, CSS, Javascript and AJAX