Add improvements and suggestions#3
Open
douglasdcm wants to merge 4 commits intoKarthikShivasankar:mainfrom
Open
Add improvements and suggestions#3douglasdcm wants to merge 4 commits intoKarthikShivasankar:mainfrom
douglasdcm wants to merge 4 commits intoKarthikShivasankar:mainfrom
Conversation
Remove useless things like __pycache__ folder and .pyc files Update the installation process Add a naive implementation to exclude directories like venv, tox... Add tqdm to inform the progress of each stage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, congratulations for the good job! The tool is promising
This MR
__pycache__foldertqdmtosetup.pyand use it insrc/code_quality_analyzer/architectural_smell_detector.pyto report the execution progressUNUSED_PARAMETERS_THRESHOLDto config.yaml to fix aKeyErrorNotes: After ignoring the undesired folders I ran the tool in your own code. It was found 9 Python files, so I supposed the execution would be vary fast, but it froze in this step. I'm very interested in this tool, but basically, I couldn't use it yet.
Other suggestions
test-requirements.txtfile to host test libraries likepytestpytestfromsetup.pyflake8bellow.argparse.ArgumentParserto a single place to make it easier to add new parameters to the toolflake8 log