Mypy cleanup. Better List usages

Author: Kartones

algorithms/hunt_and_kill.py

@@ -20,11 +20,11 @@ def on(grid: Grid) -> Grid:
 
         while current_cell is not None:
             unvisited_neighbors = \
-                [neighbor for neighbor in current_cell.neighbors if len(neighbor.links) == 0]  # type: ignore
+                [neighbor for neighbor in current_cell.neighbors if len(neighbor.links) == 0]
 
             if len(unvisited_neighbors) > 0:
                 # as long as there are unvisited paths, walk them
-                neighbor = cast(Cell, choice(unvisited_neighbors))
+                neighbor = choice(unvisited_neighbors)
                 current_cell.link(neighbor)
                 current_cell = neighbor
             else:

algorithms/sidewinder.py

@@ -24,7 +24,7 @@ def on(grid: Grid) -> Grid:
                     member = choice(run)
                     if member.north:
                         member.link(member.north)
-                    run = []
+                    run.clear()
                 else:
                     cell.link(cell.east)
         return grid

algorithms/wilson.py

@@ -15,12 +15,12 @@ class Wilson:
 
     @staticmethod
     def on(grid: Grid) -> Grid:
-        unvisited = []  # Type: List[Cell]
+        unvisited = []
         for cell in grid.each_cell():
             unvisited.append(cell)
 
         first_cell = choice(unvisited)
-        del unvisited[unvisited.index(first_cell)]
+        unvisited.remove(first_cell)
 
         while len(unvisited) > 0:
             # start a walk
@@ -39,6 +39,6 @@ def on(grid: Grid) -> Grid:
             # Passage carving once has found a valid path
             for index in range(len(path) - 1):
                 path[index].link(path[index + 1])
-                del unvisited[unvisited.index(path[index])]
+                unvisited.remove(path[index])
 
         return grid

base/cell.py

@@ -18,8 +18,8 @@ def links(self) -> List["Cell"]:
         return list(self._links.keys())
 
     @property
-    def neighbors(self) -> List[Optional["Cell"]]:
-        neighbors_list = []         # type: List[Optional[Cell]]
+    def neighbors(self) -> List["Cell"]:
+        neighbors_list = []         # type: List[Cell]
         if self.north:
             neighbors_list.append(self.north)
         if self.south:
@@ -62,7 +62,7 @@ def linked_to(self, cell: "Cell") -> bool:
     @property
     def distances(self) -> Distances:
         distances = Distances(self)
-        frontier = [self]   # type: List[Cell]
+        frontier = [self]
 
         while len(frontier) > 0:
             new_frontier = []

base/grid.py

@@ -18,6 +18,14 @@ def columns(self) -> int:
     def size(self) -> int:
         return self.rows * self.columns
 
+    @property
+    def deadends(self) -> List[Cell]:
+        deadends_list = []
+        for cell in self.each_cell():
+            if len(cell.links) == 1:
+                deadends_list.append(cell)
+        return deadends_list
+
     def __init__(self, rows: int, columns: int) -> None:
         if rows is None or rows < 0:
             raise ValueError("Rows must be a positive integer")

demos/demo_utils.py

@@ -30,6 +30,7 @@ def get_renderer(available_renderers: List[str], default_renderer: str) -> Tuple
         if key == "--renderer":
             try:
                 renderer_name = args.assignments[key][0]
+                # Hacky but only method I know to get an alias of an imported module
                 if renderer_name in available_renderers and renderer_name in globals():
                     renderer = globals()[renderer_name]
             except ValueError as error: