Skip to content

Fix ingester not exiting automatically #80

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Fix ingester not exiting automatically #80

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1cff38e
Refactor: Improve ingester robustness and flexibility
cursoragent Oct 16, 2025
3d64c6c
Refactor: Simplify embedding model selection and docker compose commands
cursoragent Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions ingesters/src/generateEmbeddings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,7 @@ async function ingestSource(source: DocumentSource): Promise<void> {
* Main function to run the ingestion process
*/
async function main() {
let exitCode = 0;
try {
// Prompt user for target
const target = await promptForTarget();
Expand All @@ -201,12 +202,18 @@ async function main() {

logger.info('All specified ingestion processes completed successfully.');
} catch (error) {
exitCode = 1;
logger.error('An error occurred during the ingestion process:', error);
} finally {
// Clean up resources
if (vectorStore) {
await vectorStore.close();
process.exit(0);
// Clean up resources and exit deterministically
try {
if (vectorStore) {
await vectorStore.close();
}
} catch (cleanupError) {
logger.warn('Error while cleaning up resources:', cleanupError);
} finally {
process.exit(exitCode);
}
}
}
Expand Down