Skip to content

[PR] Final Article Version Pull Request#3

Merged
Kaszanas merged 35 commits intomainfrom
draft_paper
Jan 13, 2026
Merged

[PR] Final Article Version Pull Request#3
Kaszanas merged 35 commits intomainfrom
draft_paper

Conversation

@Kaszanas
Copy link
Owner

@Kaszanas Kaszanas commented Jan 9, 2026

This pull request is a work in progress towards the final article and software version.

@Kaszanas
Copy link
Owner Author

@nkrusch These improvements should be ready to review. This implements #1 #2

I will make the article changes as soon as possible, Although please note that the content was cut down from ~3000 words to ~1500 words, so if I am to re-introduce some content that was found lacking, the word limit will not be respected. I leave this to be an editorial decision and will make the requested changes.

Copy link

@nkrusch nkrusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! please merge.

@nkrusch
Copy link

nkrusch commented Jan 12, 2026

(Just adding a mention to the review issue: 8889)

@Kaszanas
Copy link
Owner Author

Kaszanas commented Jan 13, 2026

@nkrusch as per the reviews I assume that I should add back the content that was originally cut out (due to the word limits) because reviewers mentioned the lack of comprehensive explanations about SC2AnonServerPy and DatasetPreparator.

These will be a susections of the Software Description section.

The final response will be available today.

@Kaszanas Kaszanas merged commit 8fe42c3 into main Jan 13, 2026
1 check passed
@nkrusch
Copy link

nkrusch commented Jan 13, 2026

@Kaszanas IIRC - the original draft was quite many pages beyond the usual JOSS scope. I would caution against such a along paper. Perhaps there is a reasonable balance, that allows including an explanation about those modules, but in a few paragraphs or a section.

@Kaszanas
Copy link
Owner Author

@Kaszanas IIRC - the original draft was quite many pages beyond the usual JOSS scope. I would caution against such a along paper. Perhaps there is a reasonable balance, that allows including an explanation about those modules, but in a few paragraphs or a section.

Thank you for responding, I am aware of the limit. I have made every effort to keep the explanations as concise as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

End-to-end examples and reproducibility Add installation and quickstart instructions

2 participants