Skip to content

Conversation

@gavinevans
Copy link

Addresses metoppv#2135

Description
This PR factors out the apply_transformation code into a function and adds leniency for unit test results when NaNs are involved.

Testing:

  • Ran tests and they passed OK
  • Added new tests for the new feature(s)

@codecov-commenter
Copy link

codecov-commenter commented Sep 22, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 10.00000% with 9 lines in your changes missing coverage. Please review.
⚠️ Please upload report for BASE (mobt_877_implement_qrf@cecd99e). Learn more about missing BASE report.

Files with missing lines Patch % Lines
...r/calibration/quantile_regression_random_forest.py 10.00% 9 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@                    Coverage Diff                    @@
##             mobt_877_implement_qrf      #18   +/-   ##
=========================================================
  Coverage                          ?   95.69%           
=========================================================
  Files                             ?      142           
  Lines                             ?    14162           
  Branches                          ?        0           
=========================================================
  Hits                              ?    13552           
  Misses                            ?      610           
  Partials                          ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Kat-90 Kat-90 merged commit 0a3e0f0 into Kat-90:mobt_877_implement_qrf Sep 23, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants