fix(api): default EmployeeInvite.Status to Pending so accept-by-code works#283
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Newly created employee invites were saved with
Status = 0because:EmployeeInviteStatus.Pendingis1, not0.EmployeeInvite.Statushad no default initializer, so it defaulted to(EmployeeInviteStatus)0.InviteAsyncnever assignedStatusexplicitly before insert.Result:
GET /api/employeeinvite/{code}filters byStatus == Pending (1)and always returned 404 for freshly created invites - exactly what staging saw with codeN72cZl.What changed
EmployeeInvite.Statusnow initialized toEmployeeInviteStatus.Pending.InviteAsyncalso setsinvite.Status = EmployeeInviteStatus.Pendingexplicitly (belt + suspenders, in case the caller passes a partially populated entity).invite.Status(the new invite, always Pending after this fix) instead ofe.Status(the row being scanned). Now correctly checks for an existing Pending invite for the same email.Verification
dotnet build- 0 errors, 0 warnings.dotnet test- 54/54 passing.N72cZlhot-patched toStatus = 1; full GET-by-code path verified to behave correctly with the new defaults.