feat(api): [AB#288] redesign employee invitation flow with Firebase account linking#301
Merged
Merged
Conversation
…ccount linking - Add EmployeeInvite email template (id 7) with friendlier copy including org and role - Add AcceptInviteRequest DTO carrying firebaseUid, firstName, lastName - Introduce IFirebaseUserManager abstraction in Business + FirebaseUserManager impl in Infrastructure (keeps FirebaseAdmin out of Business) - Rewrite AcceptInviteAsync to link Firebase UID to a new User + Employee, assign OrganizationEmployee role, and set custom claims - Add EmployeeInviteErrors.FirebaseUidRequired and AccountLinkFailed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redesign Employee Invitation Flow — API
Related: AB#288
Summary
Reworks the employee invitation flow end-to-end. The accept endpoint now links a Firebase UID (created client-side) to a fully-provisioned
User+Employee, assigns theOrganizationEmployeerole, and sets custom Firebase claims so the new hire can sign in immediately. Email copy is also friendlier.Architecture
OrganizationController.Registerpattern.IFirebaseUserManagerlives inJobFlow.Business, while the concreteFirebaseUserManagerlives inJobFlow.Infrastructure. This keepsFirebaseAdminout ofJobFlow.Business(same pattern asIFirebaseTokenValidator).Changes
EmailTemplate.EmployeeInvite = 7added;BuildEmployeeInvitenow includes org name and role with friendlier copy.AcceptInviteRequest { FirebaseUid, FirstName?, LastName? }.EmployeeInviteService.AcceptInviteAsync:FirebaseUid.Userrow, callsUpsertUser, assignsUserRoles.OrganizationEmployee.role,organizationId) + display name.Employeelinked to the newUserIdand marks the inviteAccepted.EmployeeInviteErrors:FirebaseUidRequired,AccountLinkFailed(detail).POST /employeeinvite/accept/{token}now takesAcceptInviteRequest.Verification
dotnet build— all projects clean, no warnings.Notes
Paired with UI redesign in jobflow-ui-web#feature/287.