Dev 26 versioning docker images #33

oleschwen · 2025-03-06T16:04:02Z

see Versioning of Docker images #26
builds on top of Use consistent NVFlare version #27 and should be reviewed after dev-27 use consistent nvflare version #28
should be merged after Dev 26 versioning docker images NVFlare_MediSwarm#3

Summary of changes

history contains intermediate variants replaced later (no longer visible in the diff)
use single Docker image for client, server, dashboard, tests
use version number automatically from single location when building Docker image or startup kits via script
updated documentation accordingly
server startup docker script can report packages and their licenses

…d is at correct version

…ioning-docker-images

…in console) from the container rather than from a mounted location on the host

…latest upstream 2.3.0 build

…rent versions

…ver startup kit

…ioning-docker-images

…ests

…ors and swarm participants need

…matically when generating startup kits

… scheme yet

… example

…tl application code

Ultimate-Storm · 2025-03-14T09:03:33Z

README.md


-0. **Clone the repository:**
+# Usage for Developers



Can we put the guide for swarm participants above the developers? Many of the collaborators directly went into executing the commands through the readme

Yes, and check references to "above"

Ultimate-Storm · 2025-03-14T09:10:52Z

odelia_image.version

@@ -0,0 +1,2 @@
+# version of the ODELIA Docker image, read by different scripts
+0.9


I am wondering if we can relate the version number to something live PR? I forgot what does 0.9 mean here.

Can I propose 0.26.0-dev.33 here?
0.26.0: Indicates the 26th development iteration (assuming semantic versioning).
-dev.33: Marks it as a development build tied to PR #33.

Discussed in call:
.-dev..<git rev-parse --short HEAD>
currently: 0.9-dev.20250317.c630010 (also for versions used in the swarm)
releases: omit -dev. part
script to generate startup scripts already includes this in the docker.sh scripts where it is also displayed during normal usage; should generate .zip files per startup kits containing the version number in the filename

Ultimate-Storm · 2025-03-14T10:00:18Z

README.md

-   See [application/jobs/minimal_training_pytorch_cnn/README.md](application/jobs/minimal_training_pytorch_cnn/README.md)
-3. **3D CNN for classifying breast tumors:**
-   See [3dcnn_ptl/README.md](application/jobs/3dcnn_ptl/README.md)
+## Build the Docker Image


we should do git submodule update docker_config/NVFlare/ before this right?

Yes, add this after the "clone"

…users

…users of the readme file

…file name

oleschwen added 15 commits February 26, 2025 16:59

made admin console startup script check whether code to be transferre…

68df212

…d is at correct version

removed outdated note

6d3c7be

consistently use apt, not apt-get

5e09ffa

use consistent (compact) format of list of packages to install

afc96c2

Merge branch 'dev-27-use-consistent-nvflare-version' into dev-26-vers…

7900f18

…ioning-docker-images

Copy code to nfcore image and deploy swarm training jobs (via the adm…

9b1ad8a

…in console) from the container rather than from a mounted location on the host

joint Docker image intended for server and client

1d8801d

use joint Docker image in startup kits

9eb34c6

use python package versions as before

9da4fe1

commented out NVFlare tests that do not use our version, but install …

b84111b

…latest upstream 2.3.0 build

run tests in common Docker container

030ab13

tentative new name for the Docker image, updated instructions

1888960

package name/version changed in submodule

1a612e9

cleaned up pip installations: removed multiple installations of diffe…

3abf90b

…rent versions

updated version numbers of packages no longer available

3bb74ba

oleschwen self-assigned this Mar 6, 2025

oleschwen mentioned this pull request Mar 6, 2025

Dev 26 versioning docker images KatherLab/NVFlare_MediSwarm#3

Merged

oleschwen added 11 commits March 6, 2025 17:16

updated docker image name

0ce2c23

updated version number to available version

4499fb0

added option for listing installed packages and their licenses in ser…

a84994e

…ver startup kit

Merge branch 'dev-27-use-consistent-nvflare-version' into dev-26-vers…

480cf25

…ioning-docker-images

Merge branch 'dev-27-use-consistent-nvflare-version' into dev-26-vers…

b07f182

…ioning-docker-images

Merge branch 'main' into dev-26-versioning-docker-images

d79e91e

use version number from one location for building image and running t…

1ef8b77

…ests

use version number from one location for building startup kits

21098bb

documented versioning of Docker image

82c5444

avoid "permission denied" when executing local training

26a7243

consistently use option no_pull in docker startup scripts

4d9b689

oleschwen linked an issue Mar 11, 2025 that may be closed by this pull request

Versioning of Docker images #26

Closed

2 tasks

extended instructions and split them in what developers, swarm operat…

083f428

…ors and swarm participants need

oleschwen added 8 commits March 13, 2025 13:49

replaced accidentally hard-coded site name by what gets replaced auto…

5141aaf

…matically when generating startup kits

version should be 0.something while we do not support the ODELIA data…

372315c

… scheme yet

use ODELIA image version number also in swarm project name

8ec7ca8

revert all replacements of version number

602e493

continued updating instructions in main README

fc8dcd5

updated instructions for simulation/proof of concept mode for minimal…

a47d18c

… example

updated instructions for simulation/proof of concept mode for 3dcnn_p…

a32c87d

…tl application code

updated README for building Docker images

028de33

oleschwen marked this pull request as ready for review March 13, 2025 15:10

oleschwen requested a review from Ultimate-Storm March 13, 2025 15:10

update VPN section

c630010

oleschwen changed the title ~~WIP Dev 26 versioning docker images~~ Dev 26 versioning docker images Mar 17, 2025

Ultimate-Storm requested changes Mar 17, 2025

View reviewed changes

oleschwen added 7 commits March 17, 2025 13:23

extended instructions for clone to include submodule, needed for all …

f360a4d

…users

moved instructions for swarm participants up to avoid confusing most …

d48ba01

…users of the readme file

removed outdated todo

24fbf92

create zips for each startup kit, encoding the version number in the …

12bb5a9

…file name

generate startup kit archives inside docker

cffc240

use long version number everywhere

69354d3

updated version of submodule after merge

28b0930

Ultimate-Storm approved these changes Mar 18, 2025

View reviewed changes

Ultimate-Storm merged commit 8fdbbfc into main Mar 18, 2025
3 checks passed

Ultimate-Storm deleted the dev-26-versioning-docker-images branch March 18, 2025 09:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Dev 26 versioning docker images #33

Dev 26 versioning docker images #33

Uh oh!

oleschwen commented Mar 6, 2025 •

edited

Loading

Uh oh!

Ultimate-Storm Mar 14, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

Ultimate-Storm Mar 14, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

Ultimate-Storm Mar 14, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

oleschwen Mar 17, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

		@@ -0,0 +1,2 @@
		# version of the ODELIA Docker image, read by different scripts
		0.9 No newline at end of file

Dev 26 versioning docker images #33

Dev 26 versioning docker images #33

Uh oh!

Conversation

oleschwen commented Mar 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

oleschwen commented Mar 6, 2025 •

edited

Loading