fix: recursively look for h5 files to generate slide encodings#171
Merged
mducducd merged 3 commits intoKatherLab:mainfrom Apr 21, 2026
Merged
Conversation
mducducd
approved these changes
Apr 21, 2026
| h5_path = os.path.join(feat_dir, tile_feats_filename) | ||
| slide_name: str = Path(tile_feats_filename).stem | ||
| # Recursively collect all .h5 files in feat_dir | ||
| h5_files = [p for p in feat_dir.glob("**/*.h5")] |
Collaborator
There was a problem hiding this comment.
Do you think using rglobis more appropriate here?
There was a problem hiding this comment.
Sorry, I had not seen the review! 🙏
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue similar to the one in this PR.
encode_slides_ now processes .h5 files recursively in feat_dir, preserving its original folder structure and matching the library's behavior for the preprocessing pipeline.