Merged
Conversation
This reverts commit ab50709. Already commited in other branch
georg-wolflein
suggested changes
Feb 26, 2025
Contributor
There was a problem hiding this comment.
Great work! I left a few comments for you to address, most of them minor.
Please also make sure that the workflow runs pass by fixing the formatting issues and tests. I can support you if you need help with this.
Tip: you can make sure that the unit tests pass in advance of submitting your PRs by running uv run pytest. This will allow you to catch bugs quickly; for example I found the UNI2 vs UNI_2 bug by looking at the failed tests:)
lazigu
reviewed
Mar 4, 2025
Co-authored-by: Laura Žigutytė <zigutyte@gmail.com>
georg-wolflein
approved these changes
Mar 16, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
add 6 new feature extractors: