Remove ghostscript message when converting PDFs#404
Open
Matistjati wants to merge 1 commit intoKattis:masterfrom
Open
Remove ghostscript message when converting PDFs#404Matistjati wants to merge 1 commit intoKattis:masterfrom
Matistjati wants to merge 1 commit intoKattis:masterfrom
Conversation
gkreitz
requested changes
Apr 13, 2026
| log.warning('Failed to convert %s image "%s to %s', oldext, name, newext) | ||
| result = subprocess.run(cmd, stdout=subprocess.DEVNULL, stderr=subprocess.PIPE) | ||
| if result.returncode: | ||
| log.error(f'Failed to convert {oldext} image {name} to {newext}.\n{result.stderr.decode(errors="replace")}') |
Contributor
There was a problem hiding this comment.
When logging, you want to keep printf-formatting instead of using an f-string if the data is not strictly controlled.
This will crash if any of the strings contain something looking like a printf specifier (e.g., if the error message from ghostscript happens to conrtain %s).
Contributor
|
I've fixed CI now, so please also rebase to get a nice green checkmark. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #402.
Before:
After: