Skip to content

ProofManagement extension: Iterative NodeIntermediateWalker to avoid stack overflows#3793

Merged
WolframPfeifer merged 3 commits intomainfrom
pfeifer/proofMgmtIterativeWalker
Mar 26, 2026
Merged

ProofManagement extension: Iterative NodeIntermediateWalker to avoid stack overflows#3793
WolframPfeifer merged 3 commits intomainfrom
pfeifer/proofMgmtIterativeWalker

Conversation

@WolframPfeifer
Copy link
Copy Markdown
Member

Alternative to #3789 that goes one step further: Changes NodeIntermediateWalker in proof management to an iterative instead of a recursive implementation, to avoid stack overflows.

Type of pull request

  • Bug fix (non-breaking change which fixes an issue)
  • Refactoring (behaviour should not change or only minimally change)
  • There are changes to the (Java) code

Ensuring quality

  • I made sure that introduced/changed code is well documented (javadoc and inline comments).
  • I have tested the feature as follows: manually with proof bundles

Additional information and contact(s)

The contributions within this pull request are licensed under GPLv2 (only) for inclusion in KeY.

@WolframPfeifer WolframPfeifer changed the title iterative version of NodeIntermediateWalker to avoid stack overflows ProofManagement extension: Iterative NodeIntermediateWalker to avoid stack overflows Mar 25, 2026
@WolframPfeifer WolframPfeifer self-assigned this Mar 25, 2026
@WolframPfeifer WolframPfeifer added keyext.proofmanagement Module: keyext.proofmanagement 🐞 Bug labels Mar 25, 2026
@WolframPfeifer WolframPfeifer added this to the v3.0.0 milestone Mar 25, 2026
Copy link
Copy Markdown
Member

@FliegendeWurst FliegendeWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution also works for me

@WolframPfeifer WolframPfeifer added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit b173c75 Mar 26, 2026
36 checks passed
@WolframPfeifer WolframPfeifer deleted the pfeifer/proofMgmtIterativeWalker branch March 26, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

keyext.proofmanagement Module: keyext.proofmanagement 🐞 Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants