Implement a gunicorn worker that uses uvloop#878
Merged
fafhrd91 merged 1 commit intoaio-libs:masterfrom May 17, 2016
Merged
Conversation
66acd9e to
06c7363
Compare
Member
|
Thanks |
Contributor
Author
|
Thanks, Nikolay. When are you going to issue a new release? |
Member
|
Usually @asvetlov makes releases. Let me ask him if he has time |
5 tasks
Contributor
Author
Member
|
@asvetlov do you want us to handle new releases of aiohttp? |
Member
|
Will do it in a few days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change do?
This PR provides a gunicorn worker that runs uvloop. This is something that has to be done at the worker level, since when the app is actually running, it's already too late to set up the uvloop policy.
How to test your changes?
I've updated
test/test_worker.pyto test the new worker too. Alternatively, you can run a hello world application using the new worker with$ gunicorn test:app --worker-class aiohttp.worker.GunicornUVLoopWebWorker --workers 2 --bind localhost:8080Related issue number
There is no aiohttp issue regarding this, but there is one in the uvloop project: MagicStack/uvloop#26
Checklist