-
Notifications
You must be signed in to change notification settings - Fork 0
chore upgrade python #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
9cebbe0
3432778
2c329d8
67489eb
73da19e
223b8d4
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.6.8 | ||
| 3.11 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,10 +1,11 @@ | ||
| language: python | ||
| dist: jammy | ||
| python: | ||
| - "3.6.6" | ||
| - "3.11" | ||
| # command to install dependencies | ||
| install: | ||
| - pip install -r requirements-dev.txt | ||
| - make dev | ||
| # command to run tests | ||
| script: | ||
| - flake8 sdiff tests | ||
| - nosetests | ||
| - make test | ||
| - make coverage |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,4 @@ | ||
| class DiffError(object): | ||
| class DiffError: | ||
|
|
||
| def __str__(self): | ||
| return self.message | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -4,3 +4,9 @@ ignore = F403, F405 | |
|
|
||
| [pep8] | ||
| max-line-length = 120 | ||
|
|
||
| [coverage:run] | ||
| branch = True | ||
|
|
||
| [coverage:report] | ||
| fail_under = 96 | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ | |
| from setuptools import setup, find_packages | ||
|
|
||
|
|
||
| version = '0.4.1' | ||
| version = '1.0.0' | ||
|
|
||
|
|
||
| def read(f): | ||
|
|
@@ -14,8 +14,9 @@ def read(f): | |
| ] | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Any need to upgrade this library?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. we are using v1 of this library: https://github.com/lepture/mistune/tree/v1 0.8.4 is last version of v1 then there is v2 and v3 which may break compatibility - I've have not checked but:
|
||
|
|
||
| tests_require = [ | ||
| 'nose', | ||
| 'flake8', | ||
| 'pytest >= 8', | ||
| 'coverage==7.6.1', | ||
| 'flake8==7.1.1', | ||
| 'autopep8', | ||
| ] | ||
|
|
||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
recommended to use
typeoverType?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is how pyupgrade --py36-plus works by default: tries to use typing.type which fails
Additionally typing.Type usage seems to be deprecated according to: https://docs.python.org/3.11/library/typing.html#typing
so at this point using type[My_Class] should be way to go