Skip to content

PM-947: GCP IdP command bugfixes#1880

Merged
erinlewis-keeper merged 1 commit intoPM-947-privileged-cloud-managementfrom
PM-947-gcp-bugfixes
Mar 19, 2026
Merged

PM-947: GCP IdP command bugfixes#1880
erinlewis-keeper merged 1 commit intoPM-947-privileged-cloud-managementfrom
PM-947-gcp-bugfixes

Conversation

@tbjones-ks
Copy link
Contributor

Summary

  • Fix GCP user provisioning response parsing — GCP returns name as a dict (not string like Azure), now falls back to primaryEmail
  • Add dynamic IdP User ID labels based on provider record type (Azure User ID, GCP User ID, etc.) instead of hardcoded "Azure User ID"
  • Fix pamUser record lookup to support prefix login matching (e.g., testuser matches testuser@domain.com)
  • Generalize IdP User ID custom field labels in deprovision flow

Test plan

  • Provision a GCP user via pam action idp-user-provision and verify record fields
  • Provision an Azure user and verify "Azure User ID" label
  • Deprovision a GCP user with --delete-record and verify record cleanup
  • Test prefix login matching (provision with email, deprovision with username only)

Change List:
   - Fix GCP user provisioning response parsing (handle dict name field)
   - Add dynamic IdP User ID labels based on provider type (Azure, GCP, Okta, AWS, Domain)
   - Fix pamUser record lookup to support prefix login matching (username without domain)
   - Generalize IdP User ID custom field labels in deprovision flow
@tbjones-ks tbjones-ks marked this pull request as ready for review March 19, 2026 17:04
Copy link

@erinlewis-keeper erinlewis-keeper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erinlewis-keeper erinlewis-keeper merged commit ff3458b into PM-947-privileged-cloud-management Mar 19, 2026
4 checks passed
@erinlewis-keeper erinlewis-keeper deleted the PM-947-gcp-bugfixes branch March 19, 2026 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants