Skip to content

Fix: EPM policy can not be created without name and mandatory fields. #1950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sali-ks merged 1 commit into from
Apr 16, 2026
Merged

Fix: EPM policy can not be created without name and mandatory fields. #1950

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion keepercommander/commands/pedm/pedm_admin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1335,7 +1335,7 @@ def __init__(self):
parser.add_argument('--policy-type', dest='policy_type', action='store', default='elevation',
choices=['elevation', 'file_access', 'command', 'least_privilege'],
help='Policy type')
parser.add_argument('--policy-name', dest='policy_name', action='store',
parser.add_argument('--policy-name', dest='policy_name', action='store', required=True,
help='Policy name')
parser.add_argument('--control', dest='control', action='append',
choices=['allow', 'deny', 'audit', 'notify', 'mfa', 'justify', 'approval'],
Expand Down Expand Up @@ -1432,6 +1432,14 @@ def execute(self, context: KeeperParams, **kwargs) -> None:
if policy_filter:
policy_data.update(policy_filter)

if policy_type in ('PrivilegeElevation', 'FileAccess', 'CommandLine'):
missing = [name for name, key in (('user', 'UserCheck'), ('machine', 'MachineCheck'), ('application', 'ApplicationCheck'))
if not policy_filter.get(key)]
if missing:
raise base.CommandError(
f'At least one machine, application, and user collection required to save this policy type. '
f'Missing: {", ".join(missing)}. Use --user-filter, --machine-filter, --app-filter.')

for filter_name in ('UserCheck', 'MachineCheck', 'ApplicationCheck', 'DateCheck', 'TimeCheck', 'DayCheck'):
f = policy_data.get(filter_name)
if f is None:
Expand Down
Loading