Add support for importing stringified JSON#1968
Merged
sk-keeper merged 3 commits intoKeeper-Security:releasefrom Apr 24, 2026
Merged
Add support for importing stringified JSON#1968sk-keeper merged 3 commits intoKeeper-Security:releasefrom
sk-keeper merged 3 commits intoKeeper-Security:releasefrom
Conversation
BaseFileImporter is a process of the import command which only supports a file. Added support for stringified JSON.
The JSON import supports: - JSON filename - ZIP filename Added support for stringified JSON
Removed path validation from ApplyMembershipCommand. This is required for the ApplyMembershipCommand to support stringified JSON data instead of a physical JSON file. This validation is redundant as it is done inside do_import. It is not performed in other similar commands in this file.
idimov-keeper
approved these changes
Apr 21, 2026
ccaf00a to
22d8a2d
Compare
sk-keeper
pushed a commit
that referenced
this pull request
Apr 24, 2026
* Add native JSON validation for BaseFileImporter BaseFileImporter is a process of the import command which only supports a file. Added support for stringified JSON. * Added support for stringified JSON import The JSON import supports: - JSON filename - ZIP filename Added support for stringified JSON * Remove redundant path validation in ApplyMembershipCommand Removed path validation from ApplyMembershipCommand. This is required for the ApplyMembershipCommand to support stringified JSON data instead of a physical JSON file. This validation is redundant as it is done inside do_import. It is not performed in other similar commands in this file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The JSON import command requires a physical file holding sensitive data:
Added support for passing stringified JSON as the filename, which will import the data without needing to store it in a file. This improves security, SDK use-cases, integrations with ephemeral storage.
Example command syntax:
Support for strings added to:
importcommand (JSON format only)apply-membershipcommand