KC-1314: Add vault-style passphrase generation to Commander CLI#2164
Merged
sshrushanth-ks merged 4 commits intoJun 22, 2026
Merged
Conversation
Introduce KeeperPassphraseGenerator using the bundled EFF word list and wire it into generate --passphrase and :passphrase on record-add, record-update, and nsf-record commands. Honor enterprise passphrase-* policy fields with CLI/ overrides for word count, separator, capitals, and digit. Add Vault-aligned passphrase validation in PasswordComplexityEnforcer so passphrases that meet passphrase policy pass record commands without --force, even when random password rules (upper-min, digit-min) would reject them. Includes unit tests for generation, enforcement, and existing NSF coverage.
pvagare-ks
approved these changes
Jun 19, 2026
amangalampalli-ks
approved these changes
Jun 19, 2026
|
|
||
| return failures | ||
| if not failures: | ||
| return failures |
Contributor
There was a problem hiding this comment.
We can use return [] here for clarity, since failures is always empty at this point.
sali-ks
approved these changes
Jun 22, 2026
sshrushanth-ks
merged commit 25949f1
into
commander-add-passphrase-generation
4 checks passed
sshrushanth-ks
added a commit
that referenced
this pull request
Jun 23, 2026
* Add vault-style passphrase generation with CLI overrides and validation Introduce KeeperPassphraseGenerator using the bundled EFF word list and wire it into generate --passphrase and :passphrase on record-add, record-update, and nsf-record commands. Honor enterprise passphrase-* policy fields with CLI/ overrides for word count, separator, capitals, and digit. Add Vault-aligned passphrase validation in PasswordComplexityEnforcer so passphrases that meet passphrase policy pass record commands without --force, even when random password rules (upper-min, digit-min) would reject them. Includes unit tests for generation, enforcement, and existing NSF coverage. * Fix passphrase separator handling and document allowed separator characters * Made capitals + digit on the first word as default * addressed review comment
sk-keeper
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Add vault-style passphrase generation with CLI overrides and validation Introduce KeeperPassphraseGenerator using the bundled EFF word list and wire it into generate --passphrase and :passphrase on record-add, record-update, and nsf-record commands. Honor enterprise passphrase-* policy fields with CLI/ overrides for word count, separator, capitals, and digit. Add Vault-aligned passphrase validation in PasswordComplexityEnforcer so passphrases that meet passphrase policy pass record commands without --force, even when random password rules (upper-min, digit-min) would reject them. Includes unit tests for generation, enforcement, and existing NSF coverage. * Fix passphrase separator handling and document allowed separator characters * Made capitals + digit on the first word as default * addressed review comment
sk-keeper
pushed a commit
that referenced
this pull request
Jun 23, 2026
* Add vault-style passphrase generation with CLI overrides and validation Introduce KeeperPassphraseGenerator using the bundled EFF word list and wire it into generate --passphrase and :passphrase on record-add, record-update, and nsf-record commands. Honor enterprise passphrase-* policy fields with CLI/ overrides for word count, separator, capitals, and digit. Add Vault-aligned passphrase validation in PasswordComplexityEnforcer so passphrases that meet passphrase policy pass record commands without --force, even when random password rules (upper-min, digit-min) would reject them. Includes unit tests for generation, enforcement, and existing NSF coverage. * Fix passphrase separator handling and document allowed separator characters * Made capitals + digit on the first word as default * addressed review comment
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added Vault-style passphrase generation to Commander using the bundled EFF word list, with support on generate --passphrase, $GEN:passphrase on record commands (including NSF), optional CLI overrides for word count/separator/capitals/digit, enterprise passphrase-* policy integration for generation, and Vault-aligned passphrase validation so valid passphrases are accepted on record add/update without --force when random-password rules would otherwise fail.
Changes