Use preserveModules for browser dist to enable proto.js tree-shaking by downstream bundlers#181
Merged
Conversation
…by downstream bundlers proto.js is 16.1 MB unminified. With a monolithic ES bundle, any keeperapi import pulled in the full file. preserveModules outputs one file per source module so webpack can exclude proto.js entirely from bundles that don't use protobuf (e.g. tabWorker: 16 MB → 42 KB, browser action: eliminated as an async chunk). sideEffects lists configureProtobuf so it is never dropped.
This comment has been minimized.
This comment has been minimized.
THeflinKeeper
approved these changes
Jun 23, 2026
sgaddala-ks
pushed a commit
that referenced
this pull request
Jul 1, 2026
…by downstream bundlers (#181) proto.js is 16.1 MB unminified. With a monolithic ES bundle, any keeperapi import pulled in the full file. preserveModules outputs one file per source module so webpack can exclude proto.js entirely from bundles that don't use protobuf (e.g. tabWorker: 16 MB → 42 KB, browser action: eliminated as an async chunk). sideEffects lists configureProtobuf so it is never dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
proto.js is 16.1 MB unminified / 4.81 MiB minified. With a monolithic ES bundle, any keeperapi import pulled in the full file. preserveModules outputs one file per source module so webpack can exclude proto.js entirely from bundles that don't use protobuf (e.g. tabWorker: 4.81 MiB → 40 KB minified, browser action: eliminated as an async chunk). sideEffects lists configureProtobuf so it is never dropped.