fix: embed version from release-please manifest#15
Merged
Conversation
…panic
Version was hardcoded to "dev" without ldflags, causing
semver.MustParse("dev") to panic in kh update. Now the version is
read from .release-please-manifest.json via go:embed at compile time,
so go run, go build, and go install all resolve the real version.
Ldflags from GoReleaser still take precedence for releases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.release-please-manifest.jsonviago:embedsokh versionshows the real version (0.3.0) instead ofdev— even without ldflags (go run,go build,go install)kh updatepanic:semver.MustParse("dev")crashes; now skips semver comparison when version isdevand always offers the updaterelease-please-config.jsonkeeps the copy updated on version bumpsTest plan
go run ./cmd/kh version→ shows0.3.0make build && ./bin/kh version→ shows0.3.0go run ./cmd/kh update→ detects0.3.0 < 0.4.0and updates (no panic)go test ./...→ all tests pass