Merged
Conversation
MCP serve mode ignored the --host flag for API requests because tools.go and schemas.go called ResolveHost(nil, cfg) with a nil cobra command, making the flag invisible. All API URLs resolved to the default prod host regardless of --host value. Add BaseURL func to Factory that uses the same priority chain as HTTPClient (flag > env > config > default). Replace inline ResolveHost calls in serve mode with f.BaseURL().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
kh serve --mcp --host <url>) ignored the--hostflag for API requests.tools.goandschemas.gocalledResolveHost(nil, cfg)with a nil cobra command, so the flag was invisible and all URLs resolved to the default prod host.BaseURL func() stringto Factory using the same priority chain as HTTPClient (flag > env > config > default). Replace inlineResolveHostcalls in serve mode withf.BaseURL().Changes
pkg/cmdutil/factory.go-- addBaseURLfieldcmd/kh/main.go-- extractresolveActiveHost()helper, wireBaseURLusing same priority chaincmd/serve/tools.go-- replaceResolveHost(nil, cfg)withf.BaseURL()cmd/serve/schemas.go-- samecmd/serve/serve_test.go-- wireBaseURLin test factoryTest plan
kh serve --mcp --host http://localhost:3000returns real data from local devkh serve --mcp --host https://app-staging.keeperhub.comreturns real data from staging (with CF headers)