feat: KEEP-541 surface transactionHashes in run status#66
Merged
Conversation
Add the top-level transactionHashes array (shipped by backend in KEEP-470) to RunStatusResponse and render a Transactions section after the summary in non-JSON output. Section is suppressed when empty and in JSON mode; JSON mode surfaces the field through the struct. Per-row layout: hash, node label (with [#N] when produced inside a For-Each iteration), then network preferred over chainId; chain column omitted entirely when both are absent. Watch mode prints the section between the terminal summary and the stderr error line.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
transactionHashestoRunStatusResponse(mirror of the top-level field backend KEEP-470 surfaces from/api/workflows/executions/{id}/status).TransactionHashEntryGo type — requiredhash/nodeId/nodeName, optionalchainId/network/iterationIndexas pointer fields withomitemptyso the wire shape round-trips faithfully.Per-row format, two-space gaps:
[#N]only wheniterationIndexis set (zero-indexed, raw from the API).network, fall back to barechainIdas a string, omit the column entirely when both are absent.Watch one-liner unchanged.
Test plan
go test -race ./...clean across the repogo vet ./...cleangofmt -lcleancmd/run/status_test.go:networkpreferred when bothnetworkandchainIdare setchainId-only renders as a bare numberiterationIndexrenders as[#0],[#1]--jsonmode includestransactionHashesin the payload and suppresses the human sectionkh r st <id>on a workflow with broadcast txs (single-shot, watch,--json).