feat: add --force flag and 409 duplicate handling to add command#2
Merged
Conversation
- 409 response throws descriptive error: 'This URL is already saved as "Title". Use --force to save anyway.' - --force flag on add command bypasses the backend duplicate check - Add force?: boolean to CreateBookmarkPayload type Implements Keeply-link/docs#5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
409 Conflictresponses now throw a descriptive error:This URL is already saved as "Title". Use --force to save anyway.--forceflag onkeeply addbypasses the backend duplicate checkforce?: booleanadded toCreateBookmarkPayloadPlan
https://github.com/Keeply-link/docs/blob/main/plans/5-duplicate-detection.md
Issue
Keeply-link/docs#5
Test plan
npx tsc --noEmit— cleannpm test— 12 tests passkeeply add <already-saved-url>shows helpful duplicate errorkeeply add <already-saved-url> --forcesaves successfully