Merged
Conversation
Need to read 2 bytes to get to the string, if not we get a SOH
Owner
|
Is this tested for games other than CSGO? I haven't had a chance to test it yet for other games. |
Contributor
Author
|
I have it running on all my TF2 servers, but that is all I have tested it with. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Need to read an extra byte to get to the string, if not we get a 'Start of Header' along with the string and thus it never finds anything in the message formats stringmap.
Someone will have to test and see if the protobuff version needs a change as well, as I cannot test that.