fix(skills): add unified doc output constraints#49
Merged
Conversation
closes #46 closes #47 CHANGES - Add ## General Doc Constraints section (7 rules) to all 8 output-generating skills and documentation-review - Rename ## Constraints to ## Skill Constraints in all 10 skill files including senior-mentor - New rules: Bullets (no soft-wrap), Prose lines (no soft-wrap), Optional sections, Consistency, Completeness - Canonicalize existing per-skill Characters and KISS and DRY into the shared block - Add > General Doc Constraints v1.0.0 version footer per skill for propagation tracking - Update skill-creation/assets/skill-template.md with two-section layout for future skills - Fix standup-template.md Blockers label from (Optional) to (optional) (v2.0.1) - Add Output quality dimension to documentation-review checklist and README - Update 4 skill READMEs: Last Updated to 2026-02-22, Constraints renamed to Skill Constraints IMPACT - Fixes bug #47: agents no longer soft-wrap bullet or prose content mid-sentence - Fixes bug #46: (optional) labels now stripped when populated, sections omitted when unused - meeting-memo documents 🔴🟠🟡🟢 emoji exception in Skill Constraints; canonical block stays pure - General Doc Constraints v1.0.0 is now auditable via grep across all skills
KemingHe
added
bug
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a unified documentation quality framework by adding a "General Doc Constraints" section to all output-generating skills, addressing two critical bugs where AI agents would soft-wrap content mid-sentence and fail to properly handle optional section labels in generated documents.
Changes:
- Added standardized "General Doc Constraints" section (7 rules + v1.0.0 version footer) to 9 skills that generate output documents
- Renamed "## Constraints" to "## Skill Constraints" across all 10 skill files for clarity
- Fixed standup template's inconsistent capitalization of optional label
Reviewed changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent-skills/skill-creation/assets/skill-template.md | Added General Doc Constraints section and Skill Constraints rename to template for future skills |
| agent-skills/skill-creation/SKILL.md | Added General Doc Constraints, renamed Constraints to Skill Constraints, removed duplicate Characters rule, bumped to v1.3.0 |
| agent-skills/skill-creation/README.md | Updated Last Updated date to 2026-02-22 |
| agent-skills/senior-mentor/SKILL.md | Renamed Constraints to Skill Constraints only (non-output skill), bumped to v1.1.0 |
| agent-skills/readme/SKILL.md | Added General Doc Constraints, renamed Constraints section, removed duplicate rules, bumped to v2.2.0 |
| agent-skills/readme/README.md | Updated Last Updated date to 2026-02-22 |
| agent-skills/meeting-memo/assets/standup-template.md | Fixed capitalization: (Optional) → (optional), bumped to v2.0.1 |
| agent-skills/meeting-memo/SKILL.md | Added General Doc Constraints, renamed section, added emoji exception note, bumped to v3.1.0 |
| agent-skills/meeting-agenda/SKILL.md | Added General Doc Constraints, renamed section, removed duplicates, bumped to v1.1.0 |
| agent-skills/github-pull-request/SKILL.md | Added General Doc Constraints, renamed section, removed duplicates, bumped to v3.1.0 |
| agent-skills/github-issue/SKILL.md | Added General Doc Constraints, renamed section, removed duplicates, bumped to v3.1.0 |
| agent-skills/documentation-review/SKILL.md | Added General Doc Constraints, renamed section, added Output quality dimension to checklist, bumped to v1.2.0 |
| agent-skills/documentation-review/README.md | Added Output quality row to checklist table, updated Last Updated to 2026-02-22 |
| agent-skills/contacts/SKILL.md | Added General Doc Constraints, renamed section, removed duplicates, bumped to v1.1.0 |
| agent-skills/commit-message/SKILL.md | Added General Doc Constraints, renamed section, removed duplicates, bumped to v2.1.0 |
| agent-skills/commit-message/README.md | Renamed Constraints to Skill Constraints, updated Last Updated to 2026-02-22 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #46
closes #47
CHANGES
IMPACT