Create missing_followers.py #4
Conversation
It allows to take a look at the unfollowers with two connections.json files
KendelChopp
left a comment
KendelChopp
left a comment
There was a problem hiding this comment.
Just some pretty minor changes. Thanks for checking out this repository! If you don't mind me asking, how did you find it?
Changed according to the suggestions.
KendelChopp
left a comment
KendelChopp
left a comment
There was a problem hiding this comment.
Looks good! Last couple of comments. Also, please rebase and squash and then we can get this merged! Thanks so much for adding this.
scripts/python/missing_followers.py
Outdated
| for user in connections_new['followers']: | ||
| follower_new.append(user) | ||
|
|
||
| found = None |
There was a problem hiding this comment.
Let's keep the data types consistent and have found resolve to either True or False
Same with overall
scripts/python/missing_followers.py
Outdated
| follower_new.append(user) | ||
|
|
||
| found = None | ||
| overall = None |
There was a problem hiding this comment.
Can we rename this to something like found_unfollower?
Changed according to the suggestions.
|
I hope I didn't miss something. |
scripts/python/missing_followers.py
Outdated
| for user in connections_new['followers']: | ||
| follower_new.append(user) | ||
|
|
||
| found_unfollower = False |
There was a problem hiding this comment.
My mistake. This should be something like found_still_following and the other one should be found_unfollower. Last comment: just rebase and squash your commits down to 1 and then I'll approve! Thanks 😃
So:
found_unfollower -> found_still_following
found_overall -> found_unfollower
Now the names of the variables correspond to the value.
|
I will rebase and squash it later this day.... |
|
Hey, I've a question: How do I rebase and squash? After I searched the Internet, I found out that it goes through git. As a matter of fact, I never used git to push the changes, so could you please tell me how? (I'm new to contributing to github... ) |
2 participants
It allows to take a look at the unfollowers with two connections.json files