Description
ImportService.importStrictdoc() is a 150+ line method that performs three distinct phases in sequence:
- Upsert requirements
- Create relations
- Create traceability links
Each phase has its own loop, error handling, and data transformations. The method is difficult to read, test in isolation, and maintain.
Recommendation: Extract each phase into a private method (e.g., upsertRequirements(), createRelations(), createTraceabilityLinks()). The orchestrating method becomes a clear three-step pipeline.
Location: ImportService.java, importStrictdoc() method
Traced Requirements
- GC-B006: StrictDoc Import
Impact
Maintainability — long methods are where bugs hide and where changes are most error-prone.