Skip to content

fix: stop discovered sandbox containers#22

Merged
Ker102 merged 1 commit into
mainfrom
feature/sandbox-down-targets
May 10, 2026
Merged

fix: stop discovered sandbox containers#22
Ker102 merged 1 commit into
mainfrom
feature/sandbox-down-targets

Conversation

@Ker102
Copy link
Copy Markdown
Owner

@Ker102 Ker102 commented May 10, 2026

Summary

  • make sandbox down localstack-aws discover and stop timestamped LocalStack containers created by fallback startup
  • allow explicit LocalStack container shutdown such as nullstate sandbox down localstack-20260510103849
  • keep backend shutdown scoped by expected LocalStack image and name prefix

Verification

  • python -m unittest tests.test_sandbox.SandboxTests.test_localstack_down_plan_accepts_discovered_container_names tests.test_sandbox.SandboxTests.test_sandbox_down_discovers_backend_containers tests.test_sandbox.SandboxTests.test_sandbox_down_accepts_explicit_localstack_container_name -v
  • python -m nullstate sandbox down localstack-aws --dry-run
  • python -m nullstate sandbox down localstack-20260510103849 --dry-run
  • python -m unittest tests.test_sandbox -v
  • python -m ruff check src\nullstate\cli.py src\nullstate\sandbox.py tests\test_sandbox.py
  • python -m mypy src

@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 10, 2026

Warning

Rate limit exceeded

@Ker102 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 31 minutes and 30 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 478eb86d-d7b9-4777-ab4d-0b6bc2eb2044

📥 Commits

Reviewing files that changed from the base of the PR and between 6df8b00 and c037486.

📒 Files selected for processing (3)
  • src/nullstate/cli.py
  • src/nullstate/sandbox.py
  • tests/test_sandbox.py
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feature/sandbox-down-targets

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Ker102 Ker102 merged commit 6716cd5 into main May 10, 2026
5 checks passed
@Ker102 Ker102 deleted the feature/sandbox-down-targets branch May 10, 2026 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant