Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request implements fixes and updates for uSync's root functionality, focusing on improving block element merging in datatypes and content type property merging orders. The changes include merging improvements, new configuration options for backward compatibility, and enhanced folder management through programmatic folder injection.
- Fixes block element merging logic in datatypes with wildcard path support
- Adds configuration for content type property merging orders (Compositions, tabs, templates)
- Introduces ISyncFolder collection for programmatic folder management
Reviewed Changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| uSync.SchemaGenerator/Program.cs | Adds optional site path copying functionality for schema files |
| uSync.SchemaGenerator/Options.cs | Adds new site command-line option for schema generator |
| uSync.Core/Tracking/SyncRootMergerHelper.cs | Major refactoring with wildcard path support, improved merging logic, and helper methods |
| uSync.Core/Tracking/Impliment/ContentTypeBaseTracker.cs | Updates tracking configuration for compositions and allowed templates |
| uSync.Core/Tracking/Impliment/ContentBaseTracker.cs | Disables content merging in roots to prevent confusion |
| uSync.Core/Mapping/Mappers/MemberGroupPickerMapper.cs | New mapper for member group picker functionality |
| uSync.Backoffice.Assets/Controllers/uSyncDashboardApiController.cs | Updates settings endpoint to include folder configuration |
| uSync.BackOffice/uSyncBackOfficeBuilderExtensions.cs | Registers new SyncFolderCollection for dependency injection |
| uSync.BackOffice/SyncHandlers/SyncHandlerRoot.cs | Implements legacy root merge configuration and improved export logic |
| uSync.BackOffice/Configuration/uSyncHandlerSettings.cs | Adds LegacyRootMerge configuration option |
| uSync.BackOffice/Configuration/uSyncConfigService.cs | Refactors folder management with ISyncFolder collection support |
| uSync.BackOffice/Configuration/SyncFolderCollection.cs | New collection class for managing sync folders |
| uSync.BackOffice/Configuration/ISyncfolder.cs | New interface for programmatic folder definition |
| uSync.BackOffice.Targets/appsettings-schema.usync.json | Updates JSON schema with new configuration options |
Comments suppressed due to low confidence (2)
uSync.BackOffice/Configuration/ISyncfolder.cs:1
- The filename 'ISyncfolder.cs' should follow C# naming conventions with proper casing: 'ISyncFolder.cs'.
namespace uSync.BackOffice.Configuration;
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes and updates for the root functionality: