Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR brings v13 updates to roots functionality into the v16 branch, specifically enhancing the tracking and merging capabilities for uSync root operations. The changes introduce wildcard path support, improved sorting mechanisms, and configuration options for backward compatibility.
- Adds wildcard path support (
*) in tracking paths for more flexible element matching - Implements new sorting options using
#prefix for element value sorting andSortOrderfor structured elements - Introduces configuration option for legacy full-file saving behavior during root operations
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| SyncRootMergerHelper.cs | Adds wildcard path processing, enhanced sorting logic, and utility method for removing empty XML elements |
| ContentTypeBaseTracker.cs | Updates tracking configurations with new sorting parameters for compositions, templates, and child node types |
| ContentBaseTracker.cs | Adds merge override methods that always return target content to prevent complex content merging |
| SyncHandlerRoot.cs | Implements conditional file saving logic based on new FullFileOnDifference configuration |
| uSyncHandlerSettings.cs | Adds FullFileOnDifference configuration property for backward compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bring the v13 updates to roots into the v16 branch.