Fixes: #949 - Property Editor UI alias values get overwritten on import#950
Merged
Fixes: #949 - Property Editor UI alias values get overwritten on import#950
Conversation
…lookup and check the serializer for all other ones (so the serializer has to be explicity set on migrated ones).
Contributor
There was a problem hiding this comment.
Pull request overview
Updates how EditorUIAlias is derived during data type import so that existing (non-empty) values are preserved unless an explicit override is provided by a configuration serializer—addressing issue #949 where UI alias values could be unintentionally overwritten.
Changes:
- Only auto-populate
EditorUIAliasfrom the editor alias mapping when the importedEditorUIAliasis blank. - When
EditorUIAliasis already set, consult configuration serializers for an explicitEditorUIAliasoverride (e.g., TinyMCE → TipTap migrations) and apply it if present.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the behaviour updating the EditorUIAlias value.
only do the full update on blank EditorUIAlias values, lookup and check the serializer for all other ones (so the serializer has to be explicitly set on migrated ones).