Fix alert banner overlapping with first row#220
Merged
posabsolute merged 1 commit intoKevinVandy:v2from Dec 7, 2023
Merged
Conversation
|
@laratran is attempting to deploy a commit to the Kevin Vandy OSS Team on Vercel. A member of the Team first needs to authorize it. |
posabsolute
approved these changes
Dec 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ToolbarAlertBanner would overlap with the first row of the table when positioned at the top. This was caused by adding the
alert-bottomclass to the Banner regardless of where the banner was positioned. Thealert-bottomclass adds-16pxto the bottom margin which is only necessary when the banner is at the bottom.Fixes #209.
Before
After
The bottom banner is still positioned correctly
