fix(knowledge): fix git log parser and ISSUE_RE pattern (#151)#156
Merged
fix(knowledge): fix git log parser and ISSUE_RE pattern (#151)#156
Conversation
…fies extraction Two bugs fixed: 1. Git log parser: empty line after COMMIT_END sentinel incorrectly set reading_files=false, causing ALL file paths to be skipped. Now empty lines are ignored during file reading; state resets on next COMMIT_START. 2. ISSUE_RE: added issue-NNN pattern (e.g. feat(issue-99)) which was not matched by existing regex. Added capture group 5 for issue[-]?(\d+). Fixes #151 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Kewton
force-pushed
the
feature/issue-151-file-modifies
branch
from
4ab33df to
adc2214
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
COMMIT_ENDsentinel incorrectly setreading_files=false, causing ALL file paths to be skipped duringextract_file_modifies_from_git_log. This resulted in 0 file nodes and 0 modifies edges afterindexcommand.issue[-]?(\d+)pattern to capturefeat(issue-99)style references that were previously unmatched.Changes
issue-NNNpattern in ISSUE_RE regexTest plan
cargo build— no errorscargo clippy --all-targets -- -D warnings— 0 warningscargo test --all— 498 unit tests passcargo fmt --all -- --check— cleancommandindexdev indexproduces file nodes and modifies edgescommandindexdev why src/config/z-index.tsreturns related IssuesFixes #151
🤖 Generated with Claude Code