refactor: セキュリティコメント体系統一・入力サニタイズ強化 (#574)#579
Merged
Conversation
…itization - Migrate 9 security identifiers to unified [SEC-NNN] format (SEC-010 to SEC-018) - Add security-logger.ts with SecurityAction type and logSecurityEvent helper - Add input validation to sanitizeTerminalOutput (null byte removal, 1MB truncation) - Replace direct logger.warn calls with logSecurityEvent in path-validator.ts and ip-restriction.ts - Create docs/security-identifiers.md as Single Source of Truth for identifier mappings - Update tests for new sanitization behavior and log action string changes Resolves #574 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…n tests
Update CM_TRUST_PROXY negative assertions to use the new logSecurityEvent
format ('security:trust-proxy-unexpected') instead of the stale old format.
Fix inconsistent closing brace indentation in 4 test cases.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[SEC-NNN]形式に統一（9件）sanitizeTerminalOutput()にnull byte除去・過大入力切り詰め（10KB上限）を追加security-logger.ts新規作成（logSecurityEvent()統一API）Test plan
Closes #574
🤖 Generated with Claude Code