fix(sidebar): remove fallback timer that caused full-page reloads#663
Merged
fix(sidebar): remove fallback timer that caused full-page reloads#663
Conversation
Next.js App Router defers history.pushState() to a React effect, so window.location.pathname does not update synchronously with router.push(). The 500ms fallback timer was firing before the URL updated and calling window.location.href, causing a full hard reload on every sidebar click. Remove the fallback timer and useEffect cleanup entirely; router.push() alone is sufficient for App Router navigation. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
window.location.href) fromhandleBranchClickinSidebar.tsxuseRef(fallbackTimerRef) anduseEffectcleanupRoot cause
Next.js App Router calls
window.history.pushState()inside a React effect (not synchronously withrouter.push()). This meanswindow.location.pathnameretains the old path until the React render cycle completes — which can be 500ms+ on slow RSC fetches.The fallback timer was checking
window.location.pathname !== targetPathat 500ms and triggeringwindow.location.href = targetPath(a hard full-page reload) every time, because the URL hadn't updated yet.Fix
Remove the fallback timer entirely.
router.push()is the correct way to navigate in App Router and does not need a hard-nav fallback.Test plan
npm run test:unit)🤖 Generated with Claude Code