refactor(auth): deterministic allowlist list order#1
Open
KeyCode17 wants to merge 1 commit into
Open
Conversation
Use BTreeMap so YamlAllowlistStore::list() returns entries sorted by domain. Previously a HashMap iteration could return entries in any order, which surfaced as flaky `px-cli allowlist list` output and non-reproducible audit diffs when the store is rebuilt. Added unit tests for the sort guarantee and the lookup path. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
YamlAllowlistStorefromHashMap<String, AllowlistEntry>toBTreeMap, solist()returns entries sorted by domain.Why
HashMapiteration order is non-deterministic, which makespx-cli allowlist listflaky and breaks reproducible audit diffs when the store is rebuilt.BTreeMapkeepslookup()semantics identical while giving operators a stable, sorted view.Test plan
cargo test -p pxsolver-auth --lib yaml_allowlist_store— 2/2 passingcargo fmt --all -- --checkcargo clippy --workspace --all-targets --all-featuresclean against the lefthook ruleset (-D warnings -D unwrap_used -D expect_used -D panic -D dbg_macro -D todo -D unimplemented)🤖 Generated with Claude Code