Add analyzer support to validate the stateless marshaller shapes (dotnet#72643)

Author: jkoritzinsky

docs/project/list-of-diagnostics.md

@@ -163,12 +163,12 @@ The diagnostic id values reserved for .NET Libraries analyzer warnings are `SYSL
 |  __`SYSLIB1052`__ | Specified configuration is not supported by source-generated P/Invokes |
 |  __`SYSLIB1053`__ | Specified LibraryImportAttribute arguments cannot be forwarded to DllImportAttribute |
 |  __`SYSLIB1054`__ | Use 'LibraryImportAttribute' instead of 'DllImportAttribute' to generate P/Invoke marshalling code at compile time |
-|  __`SYSLIB1055`__ | Invalid CustomTypeMarshallerAttribute usage |
+|  __`SYSLIB1055`__ | Invalid CustomMarshallerAttribute usage |
 |  __`SYSLIB1056`__ | Specified native type is invalid |
 |  __`SYSLIB1057`__ | Marshaller type does not have the required shape |
-|  __`SYSLIB1058`__ | Marshaller type defines a well-known method without specifying support for the corresponding feature |
+|  __`SYSLIB1058`__ | Invalid NativeMarshallingAttribute usage |
 |  __`SYSLIB1059`__ | Marshaller type does not support allocating constructor |
-|  __`SYSLIB1060`__ | BufferSize should be set on CustomTypeMarshallerAttribute |
+|  __`SYSLIB1060`__ | Specified marshaller type is invalid |
 |  __`SYSLIB1061`__ | Marshaller type has incompatible method signatures |
 |  __`SYSLIB1062`__ | Project must be updated with '<AllowUnsafeBlocks>true</AllowUnsafeBlocks>' |
 |  __`SYSLIB1063`__ | *_`SYSLIB1063`-`SYSLIB1069` reserved for Microsoft.Interop.LibraryImportGenerator._* |

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/AnalyzerDiagnostics.cs

@@ -24,7 +24,7 @@ public static class Ids
             public const string CustomMarshallerTypeMustHaveRequiredShape = Prefix + "1057";
             public const string InvalidNativeMarshallingAttributeUsage = Prefix + "1058";
             public const string MissingAllocatingMarshallingFallback = Prefix + "1059";
-            public const string CallerAllocConstructorMustHaveBufferSize = Prefix + "1060";
+            public const string InvalidMarshallerType = Prefix + "1060";
             public const string InvalidSignaturesInMarshallerShape = Prefix + "1061";
         }
 

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeAnalyzer.cs

@@ -70,9 +70,7 @@ private static void AddMissingMembers(DocumentEditor editor, IEnumerable<Diagnos
 
         public override ImmutableArray<string> FixableDiagnosticIds { get; } =
             ImmutableArray.Create(
-                AnalyzerDiagnostics.Ids.CustomMarshallerTypeMustHaveRequiredShape,
-                AnalyzerDiagnostics.Ids.MissingAllocatingMarshallingFallback,
-                AnalyzerDiagnostics.Ids.InvalidNativeMarshallingAttributeUsage);
+                AnalyzerDiagnostics.Ids.CustomMarshallerTypeMustHaveRequiredShape);
 
         public override async Task RegisterCodeFixesAsync(CodeFixContext context)
         {

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/CustomMarshallerAttributeFixer.cs

@@ -19,5 +19,7 @@ public DiagnosticReporter(Action<DiagnosticDescriptor, ImmutableDictionary<strin
         public static DiagnosticReporter CreateForLocation(Location location, Action<Diagnostic> reportDiagnostic) => new((descriptor, properties, args) => reportDiagnostic(location.CreateDiagnostic(descriptor, properties, args)));
 
         public void CreateAndReportDiagnostic(DiagnosticDescriptor descriptor, params object[] messageArgs) => _diagnosticFactory(descriptor, ImmutableDictionary<string, string>.Empty, messageArgs);
+
+        public void CreateAndReportDiagnostic(DiagnosticDescriptor descriptor, ImmutableDictionary<string, string> properties, params object[] messageArgs) => _diagnosticFactory(descriptor, properties, messageArgs);
     }
 }

src/libraries/System.Runtime.InteropServices/gen/LibraryImportGenerator/Analyzers/DiagnosticReporter.cs

@@ -22,7 +22,7 @@ public class NativeMarshallingAttributeAnalyzer : DiagnosticAnalyzer
         public static readonly DiagnosticDescriptor MarshallerEntryPointTypeMustHaveCustomMarshallerAttributeWithMatchingManagedTypeRule =
             new DiagnosticDescriptor(
                 Ids.InvalidNativeMarshallingAttributeUsage,
-                GetResourceString(nameof(SR.InvalidMarshallerTypeTitle)),
+                GetResourceString(nameof(SR.InvalidNativeMarshallingAttributeUsageTitle)),
                 GetResourceString(nameof(SR.EntryPointTypeMustHaveCustomMarshallerAttributeWithMatchingManagedTypeMessage)),
                 Category,
                 DiagnosticSeverity.Error,
@@ -32,7 +32,7 @@ public class NativeMarshallingAttributeAnalyzer : DiagnosticAnalyzer
         public static readonly DiagnosticDescriptor MarshallerEntryPointTypeMustBeNonNullRule =
             new DiagnosticDescriptor(
                 Ids.InvalidNativeMarshallingAttributeUsage,
-                GetResourceString(nameof(SR.InvalidMarshallerTypeTitle)),
+                GetResourceString(nameof(SR.InvalidNativeMarshallingAttributeUsageTitle)),
                 GetResourceString(nameof(SR.EntryPointTypeMustBeNonNullMessage)),
                 Category,
                 DiagnosticSeverity.Error,
@@ -42,7 +42,7 @@ public class NativeMarshallingAttributeAnalyzer : DiagnosticAnalyzer
         public static readonly DiagnosticDescriptor GenericEntryPointMarshallerTypeMustBeClosedOrMatchArityRule =
             new DiagnosticDescriptor(
                 Ids.InvalidNativeMarshallingAttributeUsage,
-                GetResourceString(nameof(SR.InvalidMarshallerTypeTitle)),
+                GetResourceString(nameof(SR.InvalidNativeMarshallingAttributeUsageTitle)),
                 GetResourceString(nameof(SR.GenericEntryPointMarshallerTypeMustBeClosedOrMatchArityMessage)),
                 Category,
                 DiagnosticSeverity.Error,