fix: Update the dots container dynamically when dimensions change #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renamed few functions and variables * Updated storybook readme and test files * Updated the codesandbox link and email * Formatted the files and readme changes * Added pull request template and style guidelines * Added version and prettier config in package.json * Fixed bug in the initial width calculation
…alculated percentage
anjuca154
requested review from
ReshmaJoshy,
bilta-keyvalue and
manacy-keyvalue
ReshmaJoshy
reviewed
Dec 29, 2023
bilta-keyvalue
requested changes
Dec 29, 2023
| const useChartContainerWidth = ( | ||
| id: string, | ||
| dependencyArray: Array<boolean | string> | ||
| dependencyArray: Array<boolean | string | number | undefined> |
There was a problem hiding this comment.
Is undefined expected as an array element ?
| for (let i = 0; i < currentDots.length - 1; i++) { | ||
| if (isDecimal(currentDots[i])) { | ||
| let remainingDecimal = | ||
| 1 - (currentDots[i] - Math.floor(currentDots[i])); |
There was a problem hiding this comment.
Math.floor(currentDots[i]) this is done in multiple places. Can we assign it to a variable and reuse ?
manacy-keyvalue
approved these changes
Dec 29, 2023
ReshmaJoshy
approved these changes
Jan 3, 2024
bilta-keyvalue
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Checklist
mainnpm testoryarn test
Description
Update the dots container dynamically when dimensions change
Screenshots (if applicable)
Additional Notes
Related Issues or PRs
Reviewer Guidelines
Testing Instructions
Checklist for Reviewers
By submitting this pull request, I confirm that my contribution is made under the terms of the MIT License.