Merged
Conversation
Contributor
Author
|
Looks like my first attempt had some unintended consequences. This approach passes all tests, but has a side effect of an extra EOL before the |
Owner
|
Hi, ~Keyang |
Contributor
Author
|
For the same reasons stated in this open issue: #87 Data in ndjson format can be easily imported into AWS Redshift, etc. It also would be consistent with the compact output of jq. |
Keyang
added a commit
that referenced
this pull request
Sep 12, 2016
Owner
|
Looks good. thanks very much. ~Keyang |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While trying to stream a large csv to ndjson, there aren't newlines between each line. Here is an example of the cli command that reproduces the issue:
Let me know if there is a better way to handle this.