Merged
Conversation
Have a look to Keyang#185 for explanation
Even though it Buffer.allocUnsafe is documented in Node, I'm getting this error in some Node versions:
```
2) CSV Converter should emit data event correctly:
Uncaught TypeError: Buffer.allocUnsafe is not a function
```
saramartinez
approved these changes
Jul 26, 2017
saramartinez
left a comment
saramartinez
left a comment
There was a problem hiding this comment.
This solves the problem for me. Thanks for finding a solution.
|
Same here, this solves issue #185 |
|
Thanks for working on this solution! 💯 |
Contributor
Author
|
All tests pass now 😃 |
Owner
|
Sorry for the delay..Thanks for this solution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Have a look to #185 for explanation