Added 'header' event. Emit the header values.#192
Merged
Keyang merged 1 commit intoKeyang:masterfrom Aug 9, 2017
brucejo75:master
Merged
Added 'header' event. Emit the header values.#192Keyang merged 1 commit intoKeyang:masterfrom brucejo75:master
Keyang merged 1 commit intoKeyang:masterfrom
brucejo75:master
Conversation
Owner
|
Thanks for the contribution. Reviewed and looks ok. |
|
Yes, thanks for the contribution. @Keyang, when will 1.1.8 be available on npm? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Took a look at the code and found that slipping in the
headerevent as described in #141 was pretty simple.Also, updated the tests and the readme.
Others can use it here while waiting for @Keyang to accept or properly integrate.