Conversation
Contributor
Bushstar
commented
Dec 1, 2025
- Resolves: Extension: better error handling if no keymaster service available #945
- Refresh app when service URLs change
- Allow UI to load even when keymaster is not contactable
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enables the wallet application to reload when service URLs are changed, and allows the UI to load even when the keymaster service is not contactable. The changes improve resilience by wrapping service calls in separate try-catch blocks and exposing the initialiseServices function to allow manual reinitialization.
Key changes:
- Exposed
initialiseServicesfunction in wallet context interfaces for both React wallet and Chrome extension - Modified service initialization error handling to prevent blocking UI load on keymaster failures
- Added service reinitialization capability to settings tabs with user feedback
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/react-wallet/src/contexts/WalletProvider.tsx | Exposed initialiseServices function in context interface and provider value |
| apps/react-wallet/src/contexts/UIContext.tsx | Split registry and current ID refresh into separate try-catch blocks for better error isolation |
| apps/react-wallet/src/components/SettingsTab.tsx | Added service reinitialization on URL save with success feedback |
| apps/chrome-extension/src/contexts/WalletProvider.tsx | Exposed initialiseServices function in context interface and provider value |
| apps/chrome-extension/src/contexts/UIContext.tsx | Split registry and current ID refresh into separate try-catch blocks for better error isolation |
| apps/chrome-extension/src/components/SettingsTab.tsx | Added service reinitialization on URL save with success feedback |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
macterra
approved these changes
Dec 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.