Skip to content

chore: reload app on service change#1100

Merged
Bushstar merged 1 commit intomainfrom
bush/app-reload-serv
Dec 1, 2025
Merged

chore: reload app on service change#1100
Bushstar merged 1 commit intomainfrom
bush/app-reload-serv

Conversation

@Bushstar
Copy link
Contributor

@Bushstar Bushstar commented Dec 1, 2025

@Bushstar Bushstar requested review from Copilot and macterra December 1, 2025 10:45
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR enables the wallet application to reload when service URLs are changed, and allows the UI to load even when the keymaster service is not contactable. The changes improve resilience by wrapping service calls in separate try-catch blocks and exposing the initialiseServices function to allow manual reinitialization.

Key changes:

  • Exposed initialiseServices function in wallet context interfaces for both React wallet and Chrome extension
  • Modified service initialization error handling to prevent blocking UI load on keymaster failures
  • Added service reinitialization capability to settings tabs with user feedback

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
apps/react-wallet/src/contexts/WalletProvider.tsx Exposed initialiseServices function in context interface and provider value
apps/react-wallet/src/contexts/UIContext.tsx Split registry and current ID refresh into separate try-catch blocks for better error isolation
apps/react-wallet/src/components/SettingsTab.tsx Added service reinitialization on URL save with success feedback
apps/chrome-extension/src/contexts/WalletProvider.tsx Exposed initialiseServices function in context interface and provider value
apps/chrome-extension/src/contexts/UIContext.tsx Split registry and current ID refresh into separate try-catch blocks for better error isolation
apps/chrome-extension/src/components/SettingsTab.tsx Added service reinitialization on URL save with success feedback

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@Bushstar Bushstar merged commit 6cfbd98 into main Dec 1, 2025
16 checks passed
@Bushstar Bushstar deleted the bush/app-reload-serv branch December 1, 2025 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Extension: better error handling if no keymaster service available

2 participants