2.5.0: CA Bundle with ConfigMap + GKE Ambient Credentials Documentation #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
…ssue with cert handling Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
…r docs and root Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
…suance flow. Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
…onds Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
…ers, if not specified.
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Signed-off-by: Matthew H. Irby <matt.irby@outlook.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
irby
changed the title
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces version 2.5.0 of command-cert-manager-issuer, adding support for ConfigMap-based CA trust bundles, enhanced CA bundle key specification, and improved ambient credential handling for Azure. The release also includes comprehensive documentation for GKE workload identity integration and trust-manager usage.
Changes:
- Added ConfigMap support for CA trust bundles alongside existing Secret support, with precedence given to ConfigMap when both are specified
- Implemented
caBundleKeyspecification to allow explicit key selection in CA bundle resources - Added timeout for Azure ambient credential fetching to enable fallback to other credential methods
- Added comprehensive GKE workload identity documentation and trust-manager integration guide
Reviewed changes
Copilot reviewed 23 out of 24 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| internal/controller/issuer_controller_test.go | Added comprehensive test suite for commandConfigFromIssuer function covering Secret/ConfigMap CA bundles, key specifications, and various authentication scenarios |
| internal/controller/issuer_controller.go | Implemented ConfigMap support and key-based CA bundle retrieval logic with proper error handling |
| internal/command/client.go | Added 10-second timeout for Azure ambient credential token requests |
| e2e/run_tests.sh | Added end-to-end tests for CA Secret/ConfigMap functionality with key specification support |
| e2e/README.md | Updated documentation for CA trust bundle configuration in e2e tests |
| e2e/.gitignore | Added gitignore rules for certificate files |
| e2e/.env.example | Added DISABLE_CA_CHECK environment variable option |
| docsource/content.md | Updated documentation with references to new CA Bundle docs and GKE ambient credentials |
| docs/ca-bundle/README.md | Added comprehensive CA bundle documentation including trust-manager integration guide |
| docs/ambient-providers/google.md | Added complete GKE workload identity configuration documentation |
| deploy/charts/command-cert-manager-issuer/values.yaml | Added Helm value for ConfigMap access RBAC configuration |
| deploy/charts/command-cert-manager-issuer/templates/* | Added RBAC resources and deployment configuration for ConfigMap access |
| config/crd/bases/* | Updated CRD definitions with new CA bundle fields |
| cmd/main.go | Added ConfigMap access flag and improved cache configuration logic |
| api/v1alpha1/issuer_types.go | Added CaBundleConfigMapName and CaBundleKey fields to IssuerSpec |
| README.md | Updated main documentation with references to CA Bundle and GKE docs |
| Makefile | Updated e2e test target to use bash script |
| CHANGELOG.md | Added v2.5.0 release notes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
deploy/charts/command-cert-manager-issuer/templates/crds/issuers.yaml
Outdated
Show resolved
Hide resolved
deploy/charts/command-cert-manager-issuer/templates/crds/clusterissuers.yaml
Outdated
Show resolved
Hide resolved
config/crd/bases/command-issuer.keyfactor.com_clusterissuers.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Signed-off-by: Matthew H. Irby <matt.irby@keyfactor.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 24 out of 25 changed files in this pull request and generated 3 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v2.5.0
Features
caBundleConfigMapNamespecification.caBundleKeyspecification on an Issuer / ClusterIssuer resource.Chores