Dev 75095/Release 3.0.0 #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…field parsing. Added support for modern Keyfactor. Moved to .net 9
…ngelog and readme.
There was a problem hiding this comment.
Pull Request Overview
This is a major version 3.0.0 release that completely rewrites the DigiCert Metadata Sync tool's sync engine to improve performance and resilience. The core changes include migrating from .NET 6 to .NET 9, replacing XML configuration with JSON, introducing comprehensive retry logic with rate limiting support, and restructuring the codebase with new client architecture.
- Complete rewrite of the sync engine with improved performance and resilience
- Migration from XML-based configuration to JSON with consolidated config directory structure
- Implementation of retry logic with automatic backoff for DigiCert rate limits
- New NLog-based logging system with structured output
Reviewed Changes
Copilot reviewed 43 out of 45 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| digicert-metadata-sync/Models/Config.cs | New JSON-based configuration model replacing XML app.config |
| digicert-metadata-sync/Clients/DigicertClient.cs | New DigiCert API client with retry logic and rate limiting support |
| digicert-metadata-sync/Clients/KeyfactorClient.cs | New Keyfactor API client with improved error handling |
| digicert-metadata-sync/MetadataSync.cs | Complete rewrite of main sync logic with new architecture |
| digicert-metadata-sync/Logic/ValueCoercion.cs | New data type coercion logic for field mapping |
| digicert-metadata-sync/config/nlog.config | New NLog configuration for structured logging |
Files not reviewed (1)
- digicert-metadata-sync/digicertsync.Designer.cs: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the bug plus:
Rewrote the sync engine to improve performance and resilience.
New retry logic now automatically backs off when rate limits are hit on DigiCert.
Config system now uses json file instead of xml, and all config files are aggregated in the config directory.
Fixed issue with new Keyfactor versions being broken due to lack of DisplayOrder in the metadata fields API.
Fixed issue with email fields not syncing properly.
Implemented a new logging system using NLog, with log files stored in the logs directory, and an nlog.config file.