Improve: GUI messages for signing algorithm in CA creation form

[dcarella]

Change description

Improve messages for signing algorithm, in CA creation form:

• Rename "Select an algorithm to activate hybrid certificates" to "None alternative signature", and localize it
• Refactor the message key ALTERNATIVESIGNINGALGORITHM to SIGNINGALGORITHM_ALTERNATIVE, and move it (better for localizators ;-))
• Fix some messages (English, French)

Note: the message "None alternative signature" is better than original, because we can select an algorithm, then select back this first option. It is not the same behavior than the Crypto Token drop list one.

Before

After

How has this been tested?

Tested in Web GUI.

Checklist before the review request

• I have performed a self-review of my code
• I have kept the patch limited to only change the parts related to the patch
• This change requires a documentation update

[primetomas]

I like the localization, but not the change to "None alternative signature". The original text makes it very easy to understand imho, while the new one makes it sounds like you should select one.

[Realiserad]

Some feedback from someone who has not been using EJBCA in a while.

I can see where David is coming from. Suppose admin A picks an alternative signing algorithm in the dropdown. Two days later, admin B is told to disable the alternative signature. When he goes into the GUI it is unclear that "disabling the alternative signature" means picking "Select an algorithm" in the dropdown.

I don't think "- None alternative signature -" is grammatically correct though. Should probably be "- No alternative signature -". Personally I think that's an improvement over what we have now.

[primetomas]

That is not a possible use case. Once the CA has been created it is not possible to edit the CA an unselect the alternative algorithm. I.e. once you created your hybrid CA there is no going back (actually there is in using the CLI, but then you really know what you're doing anyway).

[dcarella]

In "Approval Settings" (in this same form), there are drop down lists, and I don't think that anyone think "I should select one".
Maybe, like "Approval Settings", the first item should be "None" (even if "No" it's better: I agree with @Realiserad).

[primetomas]

You have not presented a good argument to change it imho. The only argument I can read above is that it "should look like the other drop-downs". I am pretty sure, all my experience says so, that we will get support issues if it looks like a "normal" drop down. This is not a normal drop down. I'd rather have more hoops to go through in order to activate hybrid than less. The help text below is not visible enough for warnings.

Can you make the final decision @mike-agrenius-kushner .

[dcarella]

My new proposal with the message "Select an alternative signing algorithm to activate hybrid certificates" in red color (style 'warning'), like another texts in the page.

Visually it's better than the previous grey small text. Now no one can miss this new awesome feature.

I keep the word "None" to be consistent with "Approval Settings" dropdown lists (in the same page).

What do you think about this new proposal @primetomas , @mike-agrenius-kushner ?

[primetomas]

We're not sure it's an awesome feature yet. The verdict is still out there on Hybrids or not, we'll see in the end.

I'll try to organize a vote to get majority voting.

[primetomas]

Hi @dcarella : sorry for taking long to get back, Tech Days came in the way. I organized a vote and unfortunately I have to report that the majority found that the original was best. Red text did not go well. Potentially they asked for a modification to the grey help text under the drop-down with something like "Hybrid signature is disabled by default, select an algorithm to enable it".

[dcarella]

Hi Tomas,
Here you are my last modifications according to the majority.

[primetomas]

Looks great. If you can just rebase for the 9.1 code I can attend to it.

[dcarella]

I had rebased, and squashed it

[dcarella]

Hi @primetomas, my PR is ready to be merged in one unique commit

[primetomas]

Internal ticket: ECA-13368