Fixed Null entry errors when Hostname and SAN is empty. #40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fiddlermikey
added a commit
that referenced
this pull request
Dec 15, 2022
* Doc updates (#27) * Added Apache License to source code and removed unfinished work comments. * Moved sql scripts to new folder * Add more context to Provider Name and SAN parms * Fixed Remove Bug Found after ReEnrollment Refactoring * Update IIS-Conversion.sql * Removed previously left in steps from initial code base. * Updated the entry parameters grid to provide additional information on required parameters. * Fixed Removal Bug and Updated Readme * Update to migration script * Pam Documentation Updates * null host name fix * null logger issue * New Test case added * Fixed Null entry errors when Hostname and SAN is empty. (#40) * Added reenrollment to store type configuration table * Removed spaces from entry parameters to match new orchestrator requirements * Changed wording on SAN enrollment parameter requirement * Update generated README Co-authored-by: Rex Wheeler <rex@fuzzytiger.com> Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Brian Hill <bhill@keyfactor.com> Co-authored-by: Adam Joyner <36858035+joynerar@users.noreply.github.com>
fiddlermikey
added a commit
that referenced
this pull request
Dec 15, 2022
* Added Apache License to source code and removed unfinished work comments. * Moved sql scripts to new folder * Add more context to Provider Name and SAN parms * Fixed Remove Bug Found after ReEnrollment Refactoring * Update IIS-Conversion.sql * Removed previously left in steps from initial code base. * Updated the entry parameters grid to provide additional information on required parameters. * Fixed Removal Bug and Updated Readme * Update to migration script * Pam Documentation Updates * Null host name (#39) * null logger issue * New Test case added * Fixed Null entry errors when Hostname and SAN is empty. (#40) * Added reenrollment to store type configuration table * Removed spaces from entry parameters to match new orchestrator requirements * Changed wording on SAN enrollment parameter requirement Co-authored-by: Bob Pokorny <55611381+rcpokorny@users.noreply.github.com> Co-authored-by: Brian Hill <76450501+bhillkeyfactor@users.noreply.github.com> Co-authored-by: Rex Wheeler <rex@fuzzytiger.com> Co-authored-by: Bob Pokorny <bpokorny@keyfactor.com> Co-authored-by: Adam Joyner <36858035+joynerar@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed the problem when Hostname or SAN was not included, the orchestrator would fail with a NULL error.
Please be aware that if the SAN is not included but the template requires it, the reenrollment will fail gracefully with an error and retry n-times before it stops. You will then be prompted to include a valid SAN.