Release23dev #92
Release23dev #92
Conversation
|
@fiddlermikey @rcpokorny @RexWheeler - Can you guys review this? I had to go through a lot to get this to merge properly and wanted to make sure I did not miss anything.... |
rcpokorny
left a comment
rcpokorny
left a comment
There was a problem hiding this comment.
Looks like the SQL code was added along with the updated ReadMe text.
One suggestion I would make (as this was done for WinCert) would be to make the Private Key Handling 'Optional' as opposed to 'Required'. I'm not sure if that would make sense or not.
fiddlermikey
left a comment
fiddlermikey
left a comment
There was a problem hiding this comment.
readme: Store Types and Stores detail sections added for new SQL Server types.
|
@fiddlermikey - can you merge this when you get a minute? My merging is blocked. |
|
@fiddlermikey Looks like we have still lost the contents of PR88, those changes need to be included here (or at least end up in the release) |
|
I think I have to redo or reapply to the branch.
Sent from my Verizon, Samsung Galaxy smartphone
Get Outlook for Android<https://aka.ms/AAb9ysg>
…________________________________
From: Rex Wheeler ***@***.***>
Sent: Thursday, November 16, 2023 11:41:34 AM
To: Keyfactor/iis-orchestrator ***@***.***>
Cc: Bob Pokorny ***@***.***>; Mention ***@***.***>
Subject: Re: [Keyfactor/iis-orchestrator] Release23dev (PR #92)
CAUTION: External Sender - Be cautious when clicking links or opening attachments. Please email ***@***.*** with any questions.
@fiddlermikey<https://github.com/fiddlermikey> Looks like we have still lost the contents of PR88, those changes need to be included here (or at least end up in the release)
—
Reply to this email directly, view it on GitHub<#92 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANII75O64AEPXHPC367F763YEZF45AVCNFSM6AAAAAA6D477XWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJUHEZDSNJZGI>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
No description provided.